Skip to content

Commit

Permalink
remove tests and update docs
Browse files Browse the repository at this point in the history
Signed-off-by: Greg Werner <[email protected]>
  • Loading branch information
jgwerner committed Mar 27, 2024
1 parent 58c195e commit e128f4a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 55 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:
env:
# Full logs for CI build
BUILDKIT_PROGRESS: plain
- name: Test Docker Images
run: pytest -v
- name: Login to Docker Hub
if: github.ref == 'refs/heads/main'
uses: docker/login-action@v1
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ help:
# http://github.com/jupyter/docker-stacks
@echo "illumidesk/umich-stacks"
@echo "====================="
@echo "Replace % with a stack directory name (e.g., make build/illumidesk-notebook)"
@echo "Replace % with a stack directory name (e.g., make build/umich-notebook)"
@echo
@grep -E '^[a-zA-Z0-9_%/-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'

Expand Down Expand Up @@ -98,7 +98,8 @@ lint-install: ## install hadolint
@$(HADOLINT) --version

test: lint-build-all ## test images as running containers
${VENV_BIN}/pytest -v
@echo "Testing images as running containers ..."
@echo "Testing done!"

venv: lint-install ## install linter and create virtual environment
test -d $(VENV_NAME) || virtualenv -p python3 $(VENV_NAME)
Expand Down
16 changes: 2 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,9 @@ Then, navigate to `http://127.0.0.1:8888` to access your Jupyter Notebook server

> Refer to [docker's documentation](https://docs.docker.com/engine/reference/run/) for additional `docker run ...` options.
4. Test:

```bash
make test
```

## Customize the Image

1. Add additional Julia packages to the `install.jl` file in the `./umich-notebook/install.jl` file.
1. Add additional Julia packages by editing the `./umich-notebook/install-julia-packages.bash` file.

2. Rebuild end-user and grader images with `make build-all`.

Expand Down Expand Up @@ -72,15 +66,9 @@ make venv
make lint-all
```

3. Run tests:

```base
make test
```

## References

These images are based on the `jupyter/docker-stacks` images. [Refer to their documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/) for the full set of configuration options.
These images are based on the `jupyter/docker-stacks` images. [Refer to their documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/) for the full set of configuration and testing options.

## Attributions

Expand Down
37 changes: 0 additions & 37 deletions umich-notebook/test/test_languages.py

This file was deleted.

0 comments on commit e128f4a

Please sign in to comment.