fix overflow number of reference contig #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
pushed a commit
to bioinformaticsorphanage/NARFMAP
that referenced
this pull request
Dec 7, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear DRAGMAP developer,
I encountered following bug with hg38 reference and additional many contigs (total1052041 contigs) .
vector::_M_range_check: __n (which is 18446744073709547104) >= this->size() (which is 1052041)This bug occurred because the maximum number of short type reference contigs was exceeded.
I fixed related short type to int. I expect this fix to have little impact on memory usage and performance.