Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AnnotationAppliesToAllZPlanes only for 3D Annotation Groups #254

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

CPBridge
Copy link
Collaborator

The attribute AnnotationAppliesToAllZPlanes is required if the AnnotationCoordinateType is 3D and should not be present otherwise (see standard).

This PR removes AnnotationAppliesToAllZPlanes when the AnnotationCoordinateType is 2D. It also adds tests for this, and a new 2D coordinate test

@CPBridge CPBridge marked this pull request as ready for review September 21, 2023 00:03
@CPBridge CPBridge self-assigned this Sep 21, 2023
@CPBridge CPBridge added the bug Something isn't working label Sep 21, 2023
@CPBridge CPBridge merged commit 016fed1 into master Oct 2, 2023
11 checks passed
@CPBridge CPBridge deleted the bug/annotation_applies_to_zplanes branch October 2, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant