-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #309 #310
Fix for #309 #310
Conversation
Hi @rhaxton, thanks for the PR. I think your code changes are good, except for the failing style checks: https://github.com/ImagingDataCommons/highdicom/actions/runs/11187492783/job/31122527504?pr=310 However, I have one nitpick... I notice that you have changed the attribute used for language code in the example SR document to Long Code Value but do not change the value (
I.e. you cannot use Long Code Value here because the value is < 16 characters. While this isn't relevant for the current PR under discussion, I think it is important that any test files we distribute are as correct as possible, as they will likely be used for tests for all sorts of other behaviour and also serve as exemplars on how to construct these files. Can you think of other correct usage of Long Code Value that we could use here instead? Or alternatively we could revert the change to the file and create a tweaked version in memory during the test by setting it with some long string nonsense value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment with requested changes
…ent Items and Descendents" This reverts commit 6d55e3c.
I reverted the test case file and added two test cases that modify in memory. I reread the test file in each case to avoid modifying / testing / reverting the shared data, hopefully that is OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your help @rhaxton
Changed sr_document.dcm test case to have a LongCodeValue tag for Language of Content
Changed search_tree in find_content_items to try all three CodeValue tags (CodeValue, LongCodeValue, URNCodeValue)