Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SR if SpacingBetweenSlices is not set #315

Merged

Conversation

Fedalto
Copy link
Contributor

@Fedalto Fedalto commented Oct 24, 2024

SpacingBetweenSlices is an optional DICOM tag, so it can not be present. Only add it to ImageLibraryEntryDescriptors if available.

`SpacingBetweenSlices` is an optional DICOM tag, so it can not be
present. Only add it to `ImageLibraryEntryDescriptors` if available.
Copy link
Collaborator

@CPBridge CPBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the help @Fedalto

@CPBridge CPBridge merged commit 0cc8cce into ImagingDataCommons:master Oct 24, 2024
7 checks passed
@Fedalto Fedalto deleted the fix-sr-image-library-optional-tags branch October 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants