[mlp] Update flash mint contracts to use ISwapRouter02 interface #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
LGTM. Changing out the existing implementation obviously means that we wont be able to use the old router interface anywhere anymore.
Afaik uniswap has deployed the SwapRouter02 everywhere though, so we should be fine.
We need to remember to also adjust the address in the deployments repo though, otherwise we will be creating DexAdapter deployments that don't work.
| @@ -45,7 +45,7 @@ export const PRODUCTION_ADDRESSES = { | |||
| router: "0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D", | |||
| }, | |||
| uniV3: { | |||
| router: "0xE592427A0AEce92De3Edee1F18E0157C05861564", | |||
| router: "0x68b3465833fb72A70ecDF485E0e4C7bD8665Fc45", | |||
There was a problem hiding this comment.
We should double check that this address is not used elsewhere, where we still need to use the old router version.
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.