-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GlobalAuctionRebalanceExtension contract, tests & utils #153
Merged
snake-poison
merged 4 commits into
master
from
snakepoison/GlobalAuctionRebalanceExtension
Oct 25, 2023
Merged
feat: GlobalAuctionRebalanceExtension contract, tests & utils #153
snake-poison
merged 4 commits into
master
from
snakepoison/GlobalAuctionRebalanceExtension
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pblivin0x
reviewed
Oct 11, 2023
pblivin0x
reviewed
Oct 11, 2023
contracts/global-extensions/GlobalAuctionRebalanceExtension.sol
Outdated
Show resolved
Hide resolved
pblivin0x
reviewed
Oct 11, 2023
pblivin0x
reviewed
Oct 11, 2023
pblivin0x
reviewed
Oct 11, 2023
pblivin0x
reviewed
Oct 18, 2023
pblivin0x
reviewed
Oct 19, 2023
pblivin0x
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
🎉 This PR is included in version 0.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
snake-poison
added a commit
that referenced
this pull request
Nov 22, 2023
commit ec7ce83 Author: SnakePoison <[email protected]> Date: Wed Oct 25 14:17:38 2023 -0400 feat: GlobalAuctionRebalanceExtension contract, tests & utils (#153) * feat: GlobalAuctionRebalanceExtension contract, tests & utils * test: adds cases that increase coverage to 100% * feat: prevent intialization when not ready. * style: update constructor docs.
snake-poison
added a commit
that referenced
this pull request
Nov 22, 2023
commit ec7ce83 Author: SnakePoison <[email protected]> Date: Wed Oct 25 14:17:38 2023 -0400 feat: GlobalAuctionRebalanceExtension contract, tests & utils (#153) * feat: GlobalAuctionRebalanceExtension contract, tests & utils * test: adds cases that increase coverage to 100% * feat: prevent intialization when not ready. * style: update constructor docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GlobalAuctionRebalanceExtension that is compatible with the DelegatedManager.
tests are at 100% and it should be ready to serve as the base for a GlobalOptimisticAuctionExtension.