Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GlobalAuctionRebalanceExtension contract, tests & utils #153

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

snake-poison
Copy link
Contributor

Adds a GlobalAuctionRebalanceExtension that is compatible with the DelegatedManager.

tests are at 100% and it should be ready to serve as the base for a GlobalOptimisticAuctionExtension.

@coveralls
Copy link

coveralls commented Oct 10, 2023

Coverage Status

coverage: 77.323% (+0.2%) from 77.128% when pulling d259734 on snakepoison/GlobalAuctionRebalanceExtension into c0b860b on master.

@pblivin0x pblivin0x self-requested a review October 18, 2023 17:01
Copy link
Contributor

@pblivin0x pblivin0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@snake-poison snake-poison merged commit ec7ce83 into master Oct 25, 2023
2 checks passed
@snake-poison snake-poison deleted the snakepoison/GlobalAuctionRebalanceExtension branch October 25, 2023 18:17
@FlattestWhite
Copy link
Contributor

🎉 This PR is included in version 0.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

snake-poison added a commit that referenced this pull request Nov 22, 2023
commit ec7ce83
Author: SnakePoison <[email protected]>
Date:   Wed Oct 25 14:17:38 2023 -0400

    feat: GlobalAuctionRebalanceExtension contract, tests & utils (#153)

    * feat: GlobalAuctionRebalanceExtension contract, tests & utils

    * test: adds cases that increase coverage to 100%

    * feat: prevent intialization when not ready.

    * style: update constructor docs.
snake-poison added a commit that referenced this pull request Nov 22, 2023
commit ec7ce83
Author: SnakePoison <[email protected]>
Date:   Wed Oct 25 14:17:38 2023 -0400

    feat: GlobalAuctionRebalanceExtension contract, tests & utils (#153)

    * feat: GlobalAuctionRebalanceExtension contract, tests & utils

    * test: adds cases that increase coverage to 100%

    * feat: prevent intialization when not ready.

    * style: update constructor docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants