Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TargetWeightWrapExtension #182

Merged
merged 26 commits into from
Sep 4, 2024
Merged

Add TargetWeightWrapExtension #182

merged 26 commits into from
Sep 4, 2024

Conversation

pblivin0x
Copy link
Contributor

No description provided.

@pblivin0x pblivin0x changed the title Add TargetWrapExtension Add TargetWeightWrapExtension Aug 20, 2024
@pblivin0x pblivin0x changed the title Add TargetWeightWrapExtension Add TargetWeightWrapExtension Aug 20, 2024
pblivin0x added 20 commits August 20, 2024 22:35
@pblivin0x
refactor TargetWeightWrapExtension:
c9de689
@pblivin0x
add updated issuance dependencies
c17a9eb
@pblivin0x
Merge branch 'add-issuance-dependencies' into target-wrap-extension
852b2b4
@pblivin0x
update setV2 fixture
4c49951
@pblivin0x
Merge branch 'add-issuance-dependencies' into target-wrap-extension
288f093
@pblivin0x
update setValuer in tests
a419209
@pblivin0x
use nav issuance
af43944
@pblivin0x
reorder declarations
252de4a
@pblivin0x
Merge branch 'add-issuance-dependencies' into target-wrap-extension
05d3120
@pblivin0x
cleanup contract, add unit tests
d580bca
@pblivin0x
Merge branch 'master' into target-wrap-extension
2cc7c56
@pblivin0x
update ether reserve logic
d1f0432
@pblivin0x
add valuation tests
0a410b3
@pblivin0x
update rebalancer check
036cff5
@pblivin0x
update wrap dependencies for integration testing
6c7aff8
@pblivin0x
refactor isRebalancing, integration testing setup
f46d53f
@pblivin0x
remove extra reserve check, add aave v2 wrap adapter
33a10cc
@pblivin0x
add wrapData, remove ether functionality, patch tests
755dbbf
@pblivin0x
add cleanups
cdf3ead
@pblivin0x
remove diff
c23238f
@pblivin0x pblivin0x requested review from edkim and ckoopmann August 28, 2024 02:38
@pblivin0x pblivin0x marked this pull request as ready for review August 28, 2024 02:38
edkim
edkim requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@edkim edkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Super clean code. I only had one suggestion about being able to wrap into yielding assets so long as the reserve is above its Min weight.

contracts/adapters/TargetWeightWrapExtension.sol Outdated Show resolved Hide resolved
contracts/adapters/TargetWeightWrapExtension.sol Outdated Show resolved Hide resolved
edkim
edkim approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@edkim edkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

ckoopmann
ckoopmann approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@ckoopmann ckoopmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Added a few nits and questions regarding edge cases / scenarios here an there. Overall great work though. 👍

contracts/adapters/TargetWeightWrapExtension.sol Show resolved Hide resolved
contracts/adapters/TargetWeightWrapExtension.sol Show resolved Hide resolved
contracts/adapters/TargetWeightWrapExtension.sol Outdated Show resolved Hide resolved
contracts/adapters/TargetWeightWrapExtension.sol Show resolved Hide resolved
contracts/adapters/TargetWeightWrapExtension.sol Show resolved Hide resolved
contracts/adapters/TargetWeightWrapExtension.sol Show resolved Hide resolved
@pblivin0x pblivin0x requested a review from ckoopmann September 3, 2024 22:13
ckoopmann
ckoopmann approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@ckoopmann ckoopmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great stuff. 👍

@pblivin0x pblivin0x merged commit 1ebd3db into master Sep 4, 2024
5 checks passed
@pblivin0x pblivin0x deleted the target-wrap-extension branch September 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckoopmann ckoopmann ckoopmann approved these changes

@edkim edkim edkim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pblivin0x @edkim @ckoopmann