Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEIC support for iPhones #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

RahulR100
Copy link
Contributor

I added this package to core packages as I believe that without it, significant functionality is lost (no photos taken on an iPhone using the default HEIC format can be uploaded). The package is also < 30Mb so it's pretty light weight.

@IndrekHaav
Copy link
Owner

I'm not entirely convinced this should be a core package, if it's only needed for one specific format.

Also, wouldn't the libheif1 package suffice? The one you added (libheif-examples) seems to include example applications, which I don't think would be necessary. Not sure what the size difference would be, though.

I'll need to find some sample HEIF images and do some testing.

@RahulR100
Copy link
Contributor Author

Hmm... I will do some testing with libheif1 but it does seem like it would cut it.

As for it being a core package... I could add this to optional and a note specifying that most photos from an iPhone would not work without this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants