add support for arbitrary SETTINGS in CREATE TABLE #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improves code quality and implementation details.
Tooling: add github actions * Add github actions to run pytest / flake8 / black * Use clickhouse:20.6 (tests fail with 21.x, 20.8) * Keep black away from pypy
This is not allowed in Clickhouse 20.8+ and would have no effect earlier versions.
Previously copying the NO_VALUE singleton would yield a different instance. This caused some problems. Now it really is a singleton.
beda42
force-pushed
the
create-table-settings
branch
from
c2fcba8 to
d7d30e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I need to pass the
allow_nullable_keysetting toCREATE TABLE, so I made a small change that allows passing arbitrary settings to an engine using asettingsargument.It works for me as it is now, but the PR would definitely need more work - tests, docs, etc.
But before I start on it, I would like to know if there is even interest in the PR, as this repo does not seem to be very active lately...
Cheers
Beda