Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Edge error handling #110

Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: add Edge error handling #110

merged 3 commits into from
Aug 5, 2024

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 30, 2024

Proposed Changes

Extends error response processing to handle Edge (OSS) errors as well. It sets InfluxDBApiException.Message value from either message (Cloud) or data.error_message / error (Edge) element value in the response body when an error occurs.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (e3ea3a4) to head (422f6b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   95.73%   95.79%   +0.05%     
==========================================
  Files          12       12              
  Lines        1079     1093      +14     
  Branches      137      140       +3     
==========================================
+ Hits         1033     1047      +14     
  Misses         11       11              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 30, 2024 12:28
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍

LGTM 🚀

@alespour alespour merged commit c0e42c8 into main Aug 5, 2024
16 checks passed
@alespour alespour deleted the feat/edge-error-handling branch August 5, 2024 09:18
@bednar bednar added this to the 0.8.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants