-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect iox::column_type::field metadata when mapping query #491
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 23 24 +1
Lines 914 960 +46
Branches 218 234 +16
=======================================
+ Hits 893 938 +45
- Misses 10 11 +1
Partials 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade the client version to 1.0.0:
export const CLIENT_LIB_VERSION = '0.12.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question about a branch in util/TypeCasting.ts
and two recommendations for improving tests.
Once the question is clarified this can be approved. It might be nice to try dynamic test generation in mocha for some of the new tests.
Hi @karel-rehor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass locally with nodejs v1.21. N.B. there was a failing test with nodejs v1.22, however it is unrelated to this PR. A note has been added to the backlog.
Changes make sense.
@karel-rehor |
Closes #
Proposed Changes
Briefly describe your proposed changes:
Checklist