Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query structured #89

Merged
merged 45 commits into from
Sep 19, 2023
Merged

feat: query structured #89

merged 45 commits into from
Sep 19, 2023

Conversation

Sciator
Copy link
Contributor

@Sciator Sciator commented Aug 11, 2023

Closes #56

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 93.43% and project coverage change: +0.23% 🎉

Comparison is base (4b9a2fd) 96.14% compared to head (37399b3) 96.38%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   96.14%   96.38%   +0.23%     
==========================================
  Files          21       22       +1     
  Lines         675      802     +127     
  Branches      161      179      +18     
==========================================
+ Hits          649      773     +124     
- Misses          6        8       +2     
- Partials       20       21       +1     
Files Changed Coverage Δ
packages/client/src/impl/QueryApiImpl.ts 82.35% <73.52%> (-9.32%) ⬇️
packages/client/src/Point.ts 94.25% <93.84%> (+3.44%) ⬆️
packages/client/src/InfluxDBClient.ts 100.00% <100.00%> (+11.53%) ⬆️
packages/client/src/PointValues.ts 100.00% <100.00%> (ø)
packages/client/src/util/generics.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sciator Sciator marked this pull request as ready for review August 21, 2023 10:32
@Sciator Sciator requested a review from bednar August 21, 2023 10:32
@Sciator Sciator force-pushed the feat-query-structured branch from 5472e3f to 9bc3b7a Compare August 21, 2023 10:35
@bednar bednar requested a review from alespour August 22, 2023 19:05
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sciator Sciator force-pushed the feat-query-structured branch from 0db38b3 to 862abcb Compare August 29, 2023 10:01
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@bednar bednar merged commit 142c458 into main Sep 19, 2023
@bednar bednar deleted the feat-query-structured branch September 19, 2023 11:40
@bednar bednar added this to the 0.3.0 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants