Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import for the module class when created without a package #163

Open
wants to merge 8 commits into
base: 2.0.0
Choose a base branch
from
Open

Add import for the module class when created without a package #163

wants to merge 8 commits into from

Conversation

kibettheophilus
Copy link
Contributor

Fixes #153

@kibettheophilus kibettheophilus marked this pull request as ready for review August 27, 2024 14:23
@arnaudgiuliani
Copy link
Member

Seems to break defaultModule generation 🤔
image

Check examples folder and try generate default modules.

@arnaudgiuliani
Copy link
Member

Also provide a test case 👍

@arnaudgiuliani arnaudgiuliani added the status:checking Ticket is currently being checked label Sep 17, 2024
@arnaudgiuliani arnaudgiuliani self-requested a review September 17, 2024 12:48
@kibettheophilus
Copy link
Contributor Author

kibettheophilus commented Sep 17, 2024 •
edited
Loading

Seems to break defaultModule generation 🤔 image

Check examples folder and try generate default modules.

@arnaudgiuliani I have pushed an update to fix this

@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented Sep 17, 2024 •
edited
Loading

Seems to build ✅ 🎉
Can you add a test case in one of the example apps?

@kibettheophilus
Copy link
Contributor Author

Seems to build ✅ 🎉 Can you add a test case in one of the example apps?

@arnaudgiuliani added a module on the root package and the existing test, not sure if that is enough.

@arnaudgiuliani
Copy link
Member

Perfect 👌

@arnaudgiuliani
Copy link
Member

build failed, will look at it

@kibettheophilus
Copy link
Contributor Author

build failed, will look at it

Great, will also try have a look at it.

@arnaudgiuliani
Copy link
Member

seems to be that:

e: file:///Users/runner/work/koin-annotations/koin-annotations/examples/android-coffee-maker/build/generated/ksp/debug/kotlin/org/koin/ksp/generated/RootModuleGen.kt:8:12 Type expected

e: file:///Users/runner/work/koin-annotations/koin-annotations/examples/android-coffee-maker/build/generated/ksp/debug/kotlin/org/koin/ksp/generated/RootModuleGen.kt:8:23 Property getter or setter expected

@arnaudgiuliani arnaudgiuliani added this to the 2.0 milestone Oct 15, 2024
@kibettheophilus
Copy link
Contributor Author

So it finally build without any updates😅.

@arnaudgiuliani arnaudgiuliani deleted the branch InsertKoinIO:2.0.0 October 16, 2024 15:33
@arnaudgiuliani arnaudgiuliani changed the base branch from 1.4.0 to 2.0.0 October 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudgiuliani arnaudgiuliani arnaudgiuliani approved these changes

Assignees
No one assigned
Labels
status:checking Ticket is currently being checked
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kibettheophilus @arnaudgiuliani