-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: Move three internal helper functions into the unnamed namespace #72
STYLE: Move three internal helper functions into the unnamed namespace #72
Conversation
@dzenanz Some CI failures from build-macos-arm-py (10) from https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/actions/runs/10683486429/job/29611671206?pr=72#step:8:198
Do you have a clue? At least I think they are unrelated to this pull request 😇 |
https://github.com/InsightSoftwareConsortium/ITKMontage suffers from the same error, I don't know what broke, or how. What are the chances for you to get to it this week? |
I might get to it next week, unless someone else gets to it before then. |
Ahh, someone else is already on it: InsightSoftwareConsortium/ITKPythonPackage#283 |
@dzenanz Can you please rerun the CI for build-macos-arm-py, for this pull request? Or otherwise just merge, and pray that it's okay 😺 |
The fix is ready. Let me apply it to this repo too. |
I am hoping this should be enough to fix it: #73. |
Rebasing on |
Moved `writeJson`, `jsonRead`, and `addCoordinateTransformations` into the unnamed namespace of "itkOMEZarrNGFFImageIO.cxx". Following C++ Core Guidelines, May 11, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities
750d922
to
9bb60da
Compare
Now Build, test, package / build-windows-python-packages (8) fails, saying:
Any clue? |
That is most likely some network hiccup. We can re-run failed tests one the others finish running. |
Moved
writeJson
,jsonRead
, andaddCoordinateTransformations
into the unnamed namespace of "itkOMEZarrNGFFImageIO.cxx".Following C++ Core Guidelines, May 11, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities