Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing classifier to pyproject.toml and badge to README #1272

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

yangdanny97
Copy link
Contributor

Summary

Add typing :: types classifier so that the package will be eligible for https://shields.io/badges/py-pi-types

Add the badge to the README (until the package is released again it will show as untyped)

Test Plan

CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This badge will say "untyped" until I make a new release on pypi, right? That's a bit unfortunate

@yangdanny97
Copy link
Contributor Author

I can split the tag & badge into separate PRs if you don't want that

@zsol
Copy link
Member

zsol commented Jan 4, 2025

I don't mind :)

@zsol zsol merged commit c4e7934 into Instagram:main Jan 4, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants