Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in worldedit-features.md #109

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ProjectHSI
Copy link

Overview

Fixes a typo in worldedit-features.md. More specifically, a spelling mistake was made with FastAsyncWorldEdit. It was spelled "FasAsyncWorldEdit."

Description

See above.

Submitter Checklist

@ProjectHSI ProjectHSI requested a review from a team as a code owner July 2, 2024 08:42
Copy link
Member

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not open a PR because of one word or one character. Please bundle typos in a PR

@ProjectHSI
Copy link
Author

do you mean bundle multiple more typos in a single pr or put this into an already existing pr (i do have one but it's not related to typos)?

@TheMeinerLP
Copy link
Member

bundle multiple more typos in a single pr

@ProjectHSI
Copy link
Author

ProjectHSI commented Jul 2, 2024

not done yet, 2 out of several more to go

@ProjectHSI
Copy link
Author

alright i'm done. fixed many sentence mistakes in the top-level of plotsquared.

please tell me if i misinterpreted anything - i have interpreted everything to the best of my ability

@@ -29,7 +29,7 @@ worlds:

_`<world>` indicates the name of that plotworld._

You can use [Vanilla block tags](vanilla-tags.md) too.
You can use [vanilla block tags](vanilla-tags.md) too.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Vanilla more like a proper name?

Copy link
Author

@ProjectHSI ProjectHSI Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I treat "vanilla" as an adjective due to where it's used "I like vanilla Minecraft," for instance. If you treat "Vanilla Minecraft" as the whole proper noun (I.E. including the "vanilla" into the proper noun) I'm fine with that interpretation too.

@RedstoneFuture
Copy link
Member

Otherwise: good changes. Thank you.

plotsquared/vanilla-tags.md Outdated Show resolved Hide resolved

Tags are part of Vanilla Minecraft itself. For example, vanilla block tags are used for various block properties, vanilla item tags are used for various item properties, vanilla advancement files and vanilla recipe files, and vanilla entity type tags are used for various mob properties.
Tags are part of Vanilla Minecraft itself. For example, vanilla block tags are used for various block properties, vanilla item tags are used for various item properties, vanilla advancement files are used for various advancements, vanilla recipe files are used for various recipes, and vanilla entity type tags are used for various mob properties.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vanilla is uppercase here, but was made lowercase elsewhere

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, it's a mix in the sentence as a whole

@ProjectHSI
Copy link
Author

ProjectHSI commented Jul 2, 2024

gonna post this here to get a consensus from the team since it's a bit weird in the documentation:

Do you think that "Vanilla" is an adjective (as in, should be lowercase, as in "vanilla Minecraft") or do you think it is apart of the proper noun of "Minecraft" (as in, it should be capitalized, as in "Vanilla Minecraft")?

(no polls feature, so just comment)

@ProjectHSI
Copy link
Author

ProjectHSI commented Jul 3, 2024

note: just rebased the repo (apparently that messed up all the commit signing statuses)

@RedstoneFuture
Copy link
Member

gonna post this here to get a consensus from the team since it's a bit weird in the documentation:

Do you think that "Vanilla" is an adjective (as in, should be lowercase, as in "vanilla Minecraft") or do you think it is apart of the proper noun of "Minecraft" (as in, it should be capitalized, as in "Vanilla Minecraft")?

(no polls feature, so just comment)

I would be in favor of "Vanilla". But the main thing is that it is uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants