Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ProtocolUTXOCostPerWord feature #339

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Oct 24, 2023

Changelog

- description: |
    Delete `ProtocolUTXOCostPerWord` feature
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Delete ProtocolUTXOCostPerWord feature

This PR is currently not branched off tip of main so that I can build this IntersectMBO/cardano-cli#400

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/delete-ProtocolUTxOCostPerWordFeature branch from 17b2fd4 to 7e13a2a Compare October 24, 2023 10:00
@newhoggy newhoggy marked this pull request as ready for review October 24, 2023 10:00
@newhoggy newhoggy force-pushed the newhoggy/delete-ProtocolUTxOCostPerWordFeature branch 2 times, most recently from 2e83b88 to e14153c Compare October 24, 2023 10:30
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small comment.

import Lens.Micro

-- Ideally this should be defined in cardano-ledger
invalidBeforeL :: Lens' ValidityInterval (StrictMaybe SlotNo)
Copy link
Contributor

@Jimbo4350 Jimbo4350 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you talk to @lehins about this? If the intention is to move this to ledger, we should put this in Cardano.Api.ReexposeLedger.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can definitely add this to the cardano-ledger-api. Feel free to submit a PR that adds them to this module an exports these lenses together with ValidityInterval:
https://github.com/input-output-hk/cardano-ledger/blob/8415ca55d91f3b4e50c10c80215a16ca707592e5/libs/cardano-ledger-api/src/Cardano/Ledger/Api/Tx/Body.hs#L34

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will do!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhoggy newhoggy force-pushed the newhoggy/delete-ProtocolUTxOCostPerWordFeature branch from e14153c to 0c299d1 Compare October 25, 2023 10:52
@newhoggy newhoggy enabled auto-merge October 25, 2023 10:58
@newhoggy newhoggy added this pull request to the merge queue Oct 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2023
@newhoggy newhoggy added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit c9f4831 Oct 25, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/delete-ProtocolUTxOCostPerWordFeature branch October 25, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants