-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete ProtocolUTXOCostPerWord
feature
#339
Delete ProtocolUTXOCostPerWord
feature
#339
Conversation
17b2fd4
to
7e13a2a
Compare
2e83b88
to
e14153c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One small comment.
import Lens.Micro | ||
|
||
-- Ideally this should be defined in cardano-ledger | ||
invalidBeforeL :: Lens' ValidityInterval (StrictMaybe SlotNo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you talk to @lehins about this? If the intention is to move this to ledger, we should put this in Cardano.Api.ReexposeLedger
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can definitely add this to the cardano-ledger-api
. Feel free to submit a PR that adds them to this module an exports these lenses together with ValidityInterval
:
https://github.com/input-output-hk/cardano-ledger/blob/8415ca55d91f3b4e50c10c80215a16ca707592e5/libs/cardano-ledger-api/src/Cardano/Ledger/Api/Tx/Body.hs#L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e14153c
to
0c299d1
Compare
Changelog
Context
Delete
ProtocolUTXOCostPerWord
featureThis PR is currently not branched off tip of main so that I can build this IntersectMBO/cardano-cli#400
Checklist