Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default genesis parameters yielding positive treasury #425

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 12, 2024

Changelog

- description: |
    Default genesis parameters yielding positive treasury
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Without non-zero rho and tau, treasury is not growing.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@@ -129,6 +134,8 @@ shelleyGenesisDefaults =
, sgMaxLovelaceSupply = 0
}
where
unsafeUI :: Rational -> Ledger.UnitInterval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ledger has: unsafeBoundRational

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's a test module. Do we want to introduce a dependency on a test module?

@carbolymer carbolymer force-pushed the mgalazyn/fix/genesis-with-positive-reserves branch from a10ca6e to e461e2a Compare January 15, 2024 17:37
@carbolymer carbolymer force-pushed the mgalazyn/fix/genesis-with-positive-reserves branch 4 times, most recently from 82e3d8f to 8447322 Compare January 30, 2024 16:19
@carbolymer carbolymer force-pushed the mgalazyn/fix/genesis-with-positive-reserves branch 2 times, most recently from b1fb00b to 2a2d0dd Compare March 5, 2024 08:28
@carbolymer carbolymer changed the title Genesis parameters yielding positive reserves Genesis parameters yielding positive treasury Mar 5, 2024
@carbolymer carbolymer changed the title Genesis parameters yielding positive treasury Default genesis parameters yielding positive treasury Mar 5, 2024
@carbolymer carbolymer marked this pull request as ready for review March 5, 2024 08:32
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but move the new function to Cardano.Api.Utils

cardano-api/internal/Cardano/Api/Ledger/Types.hs Outdated Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/fix/genesis-with-positive-reserves branch from 2a2d0dd to a7f5ace Compare March 5, 2024 13:55
@carbolymer carbolymer added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 10acff0 Mar 5, 2024
23 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/genesis-with-positive-reserves branch March 5, 2024 14:19
newhoggy added a commit that referenced this pull request Mar 11, 2024
…t-types-for-drep-commands

Command argument types for `drep` commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants