Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose remaining functions and types from cardano-ledger-* required by cardano-cli #656

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Expose remaining functions and types from cardano-ledger-* required by cardano-cli #656

merged 3 commits into from
Oct 18, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 17, 2024

Changelog

- description: |
    Expose transitive dependencies from `cardano-ledger` needed by `cardano-cli`
    Breaking change: `Cardano.Api.Ledger` no longer exports Byron's `Tx` but it is now exported in `Cardano.Api.Byron`
  type:
  - breaking       # the API has changed in a breaking way

Context

As part of the work targeted at addressing issues pointed out in #608, this PR aims to provide cardano-cli with everything it needs from ledger.

How to trust this PR

Make sure it is just a refactoring.

Look at it in conjunction with: IntersectMBO/cardano-cli#941

Take advantage that there are one commit for shelley, one for core, and one for api (same for the corresponding PR in cardano-cli)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Oct 17, 2024
@palas palas linked an issue Oct 17, 2024 that may be closed by this pull request
[FEATURE] - Documentation and Integration Clarification #608
Closed
@palas palas mentioned this pull request Oct 17, 2024
Merged
3 tasks
@palas palas force-pushed the remove-transitive-deps-ledger-backport2 branch from f85788e to e584cc2 Compare October 18, 2024 11:23
@palas palas added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@palas palas added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@palas palas added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 07ca594 Oct 18, 2024
25 checks passed
@palas palas deleted the remove-transitive-deps-ledger-backport2 branch October 18, 2024 13:44
coot pushed a commit that referenced this pull request Oct 21, 2024
@palas @coot
Merge pull request #656 from IntersectMBO/remove-transitive-deps-ledg…
77c57d6 
…er-backport2

Expose remaining functions and types from `cardano-ledger-*` required by `cardano-cli`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@carbolymer carbolymer Awaiting requested review from carbolymer

@smelc smelc Awaiting requested review from smelc

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
Technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Documentation and Integration Clarification
2 participants
@palas @Jimbo4350