Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main references in GHA #670

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Update main references in GHA #670

merged 2 commits into from
Oct 31, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 31, 2024

Changelog

- description: |
    Fix dependencies to `main` in GHA
  type:
  - maintenance

Context

This follows up on the renaming of the default branch from main to master.

How to trust this PR

If the CI passes it will be a great sign.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Oct 31, 2024
@palas palas requested review from Jimbo4350, newhoggy, carbolymer, smelc and a team as code owners October 31, 2024 15:22
carbolymer
carbolymer approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update bin/check-git-dependencies and RELEASING.md as well? There are some references in comments to main.

@palas palas enabled auto-merge October 31, 2024 15:41
@palas palas added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 31, 2024
@smelc smelc added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit a0df586 Oct 31, 2024
25 checks passed
@smelc smelc deleted the update-references-gha branch October 31, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

Assignees

@palas palas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palas @carbolymer @smelc