Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Convert typeclass #690

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Implement Convert typeclass #690

merged 1 commit into from
Nov 26, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Nov 25, 2024 •
edited
Loading

Changelog

- description: |
    We introduce the `Convert` type class as an alternative to cardano-ledger's `Inject` typeclass.
    While `Inject` is more general, `Convert` is specifically designed for transformations between era-indexed types, 
    making the intent clearer at call sites where we're converting between eons. 

  type:
  - feature        # introduces a new feature

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/inject-era-class branch from 8ee1677 to 5bf4b4c Compare November 25, 2024 16:45
@Jimbo4350
We introduce the Convert type class as an alternative to cardano-le…
a16541b 
…dger's `Inject` typeclass.

While `Inject` is more general, `Convert` is specifically designed for transformations between era-indexed types,
making the intent clearer at call sites where we're converting between eons.
@Jimbo4350 Jimbo4350 force-pushed the jordan/inject-era-class branch from 5bf4b4c to a16541b Compare November 25, 2024 17:44
@Jimbo4350 Jimbo4350 mentioned this pull request Nov 25, 2024
Merged
3 tasks
smelc
smelc approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Jimbo4350 Jimbo4350 merged commit 1e4a1e7 into master Nov 26, 2024
27 of 29 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/inject-era-class branch November 26, 2024 13:43
This was referenced Nov 27, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jimbo4350 @carbolymer @smelc