Make "transaction view" command fail and advice to use "debug transac…

…tion view" instead
IntersectMBO · Aug 6, 2024 · cdc61ce · cdc61ce
1 parent 7062433
commit cdc61ce
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 18 deletions.
diff --git a/cardano-cli/src/Cardano/CLI/Legacy/Commands/Transaction.hs b/cardano-cli/src/Cardano/CLI/Legacy/Commands/Transaction.hs
@@ -135,9 +135,6 @@ data LegacyTransactionCmds
   | TransactionTxIdCmd
       InputTxBodyOrTxFile
   | TransactionViewCmd
-      ViewOutputFormat
-      (Maybe (File () Out))
-      InputTxBodyOrTxFile
 
 renderLegacyTransactionCmds :: LegacyTransactionCmds -> Text
 renderLegacyTransactionCmds = \case

diff --git a/cardano-cli/src/Cardano/CLI/Legacy/Options.hs b/cardano-cli/src/Cardano/CLI/Legacy/Options.hs
@@ -300,7 +300,7 @@ pTransaction envCli =
         (Opt.info pTransactionId $ Opt.progDesc "Print a transaction identifier.")
     , subParser "view" $
         Opt.info pTransactionView $
-          Opt.progDesc "Print a transaction."
+          Opt.progDesc "This command has been removed. Please use \"debug transaction view\" instead."
     ]
  where
   -- Backwards compatible parsers
@@ -488,10 +488,7 @@ pTransaction envCli =
 
   pTransactionView :: Parser LegacyTransactionCmds
   pTransactionView =
-    TransactionViewCmd
-      <$> pTxViewOutputFormat
-      <*> pMaybeOutputFile
-      <*> pInputTxOrTxBodyFile
+    pure TransactionViewCmd
 
 pNodeCmds :: Parser LegacyNodeCmds
 pNodeCmds =

diff --git a/cardano-cli/src/Cardano/CLI/Legacy/Run/Transaction.hs b/cardano-cli/src/Cardano/CLI/Legacy/Run/Transaction.hs
@@ -152,8 +152,8 @@ runLegacyTransactionCmds = \case
     runLegacyTransactionHashScriptDataCmd scriptDataOrFile
   TransactionTxIdCmd txinfile ->
     runLegacyTransactionTxIdCmd txinfile
-  TransactionViewCmd yamlOrJson mOutFile txinfile ->
-    runLegacyTransactionViewCmd yamlOrJson mOutFile txinfile
+  TransactionViewCmd ->
+    runLegacyTransactionViewCmd
   TransactionPolicyIdCmd sFile ->
     runLegacyTransactionPolicyIdCmd sFile
   TransactionWitnessCmd txBodyfile witSignData mbNw outFile ->
@@ -508,14 +508,10 @@ runLegacyTransactionTxIdCmd txfile =
         txfile
     )
 
-runLegacyTransactionViewCmd
-  :: ViewOutputFormat -> Maybe (File () Out) -> InputTxBodyOrTxFile -> ExceptT TxCmdError IO ()
-runLegacyTransactionViewCmd
-  _yamlOrJson
-  _mOutFile
-  _inputTxBodyOrTxFile =
-    runTransactionViewCmd
-      Cmd.TransactionViewCmdArgs
+runLegacyTransactionViewCmd :: ExceptT TxCmdError IO ()
+runLegacyTransactionViewCmd =
+  runTransactionViewCmd
+    Cmd.TransactionViewCmdArgs
 
 runLegacyTransactionWitnessCmd
   :: ()