Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in Commands/Query.hs #983

Open
smelc opened this issue Nov 28, 2024 · 1 comment · May be fixed by #985
Open

Reduce duplication in Commands/Query.hs #983

smelc opened this issue Nov 28, 2024 · 1 comment · May be fixed by #985
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smelc
Copy link
Contributor

smelc commented Nov 28, 2024

While working on query proposals, I noticed that many many fields are duplicated in a number of records in

This issue keeps track of sharing all these fields in a nested record.

@smelc smelc added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2024
@smelc smelc self-assigned this Nov 28, 2024
@carbolymer
Copy link
Contributor

carbolymer commented Nov 29, 2024

I'm not sure that would be a big improvement here. So instead of punning:

QueryStakeAddressInfoCmdArgs{ nodeSocketPath, consensusModeParams, networkId, mOutfile}

I imagine you'd do something like

QueryStakeAddressInfoCmdArgs{ onlineCmdArgs=OnlineCmdArgs{ nodeSocketPath, consensusModeParams, networkId, mOutfile}}

which adds more characters and some indirection. We would save some duplication on parsers though.

I'm not blocking this, just my two cents. I'm ok with trying to do it. 👍🏻

@smelc smelc linked a pull request Nov 29, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants