-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share code in fields of queries #985
base: master
Are you sure you want to change the base?
Conversation
4aff890
to
4a6f48c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should exclude the output file from the refactor. It's a UI wart IMO but the rest of the refactor is 👍. I'm sure @CarlosLopezDeLara would agree here. I also think leaving the original out-file
help is more informative.
--op-cert-file FILEPATH Filepath of the node's operational certificate. | ||
--out-file FILEPATH Optional output file. Default is to write to stdout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change? It was more informative before.
( --mainnet | ||
| --testnet-magic NATURAL | ||
) | ||
[--out-file FILEPATH] | ||
--address ADDRESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the downside of the refactor. It affects the parsers and I would argue having --out-file
as the last argument is more natural. More and more I wish for monadic parsers.
Changelog
Context
Fixes #983
How to trust this PR
Checklist