Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fourmolu, cabal-gild, and update hooks #835

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Add fourmolu, cabal-gild, and update hooks #835

merged 5 commits into from
Jul 15, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 11, 2024

Changelog

- description: |
    Added fourmolu and cabal-gild, and updated hooks
  type:
    - maintenance    # not directly related to the code

Context

We don't want to have to worry about formatting .hs or .cabal files, and we want to be consistent. This PR tries to address this by establishing and enforcing strong formatters (formoulu, and cabal-gild), which are now applied in addition to stylish-haskell and hlint.

How to trust this PR

Probably check that the hook works for you. Also that you are happy with the changes and configuration, and that the CI passes. Probably look at each commit independently.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Jul 11, 2024
@palas palas self-assigned this Jul 11, 2024
@palas palas force-pushed the apply-formatting branch 2 times, most recently from 518aa89 to 3466978 Compare July 11, 2024 19:49
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If those are the same changes as in IntersectMBO/cardano-api#583 I'm ok with them. I'm blocking merge temporarily to test drive them in cardano-api a bit before we propagate the changes to CLI.

@palas
Copy link
Contributor Author

palas commented Jul 12, 2024

If those are the same changes as in IntersectMBO/cardano-api#583 I'm ok with them. I'm blocking merge temporarily to test drive them in cardano-api a bit before we propagate the changes to CLI.

@carbolymer: Makes sense. Until when do you think we should wait?

scripts/devshell/prettify Show resolved Hide resolved
scripts/devshell/prettify Show resolved Hide resolved
scripts/devshell/prettify Outdated Show resolved Hide resolved
@palas palas added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 23e4354 Jul 15, 2024
23 checks passed
@palas palas deleted the apply-formatting branch July 15, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants