Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share code in parsers of protocol version #869

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Aug 21, 2024

Changelog

- description: |
    Share code in parsers of protocol version
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Spin-off of #864

How to trust this PR

  • It doesn't change the runtime behavior
  • I took the best bits of the two parsers (help messages, METAVAR)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review August 21, 2024 08:37
@smelc smelc added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 22, 2024
@carbolymer carbolymer added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 22, 2024
@smelc smelc added this pull request to the merge queue Aug 22, 2024
@smelc smelc removed this pull request from the merge queue due to a manual request Aug 22, 2024
@smelc smelc merged commit a105463 into main Aug 22, 2024
26 of 27 checks passed
@smelc smelc deleted the smelc/share-parsers-code branch August 22, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants