Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up remainings of query constitution-hash #871

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Aug 21, 2024

Changelog

- description: |
    Cleaned up remainings of constitution-hash query
# uncomment types applicable to the change:
  type:
  - refactoring    # QoL changes

Context

This is a follow-up of IntersectMBO/cardano-node#5920 (comment)

Investigation showed that removal of query constitution-hash was a conscious decision motivated to it no longer being relevant since its functionality is already covered by query constitution:

How to trust this PR

I think the fact that tests pass and that it compiles are pretty telling. Maybe check the context and let me know if you foresee that this removal will have effects somewhere else, but I doubt.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erikd erikd added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit fd7a3d0 Aug 22, 2024
25 checks passed
@erikd erikd deleted the cleanup-query-constitution-hash-remainings branch August 22, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants