create-testnet-data: better behavior for create-testnet-data --total-supply and --delegated-supply

[smelc]

Changelog

- description: |
    create-testnet-data's --total-supply option doesn't have a default anymore. The default value is to take the value from the shelley genesis file (if provided, otherwise this file is defaulted, so total supply comes from the default shelley genesis). create-testnet-data's --delegated-supply option doesn't have a default anymore. The default is to use half of the total supply.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Contributes to fixing IntersectMBO/cardano-node#5953

The API for create-testnet-data's total supply and delegated supply was bad:

1. --total-supply had a default value. So we would never pick up the value coming from the shelley genesis file. Now the behavior is that, if --total-supply is specified, it overrides the value from the shelley genesis file. Because the shelley genesis file is defaulted, there is always a value available.
2. --delegated-supply had a default value. This does not play well with the value of total supply coming from either the genesis file or --total-supply. Now the default is to take half of the total supply (no matter from where it comes from).

How to trust this PR

• Tested with cardano-testnet at fecf2bf0c728060c0ff408d2a7fecc152c25dd4f

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[Jimbo4350]

Rather than checking a single value, why not do a golden test on the entire genesis value?

[smelc]

@Jimbo4350> I hadn't done it initially, because the generated genesis file is not stable.

However, I brought cardano-node's redactJsonFieldsInFile function to redact the unstable fields, and I now made this a golden test.

[smelc]

@Jimbo4350> I did that in an additional commit (that I will fixup later on), to make your review easier.

[Jimbo4350]

LGTM!

[Jimbo4350]

We shouldn't hardcore the era here. Use eraToString.

[smelc]

Actually there is no era witness floating around here. This is the one place where we define the era. (and by the way, eraToString is not a thing in CLI nor API, it's a cardano-testnet thing)(which maybe we should move to API?).

So I'm merging like this.

[Jimbo4350]

The property name should be updated. It's a golden test of the output of create-testnet-data.

[smelc]

Done 👍