Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new inject function instead of the XToY era functions #969

Closed
wants to merge 2 commits into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 15, 2024

Changelog

- description: |
    Use new inject function instead of the XToY era functions
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Adapt CLI to IntersectMBO/cardano-api#636

How to trust this PR

Good question. Because tests still pass and golden files didn't change?

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc added the next-update Needs a dependency to be updated to be merged label Nov 15, 2024
@smelc smelc force-pushed the smelc/use-inject-instead-of-XtoY-era-functions branch from b9c394f to 9c3bac2 Compare November 15, 2024 09:50
@smelc smelc marked this pull request as ready for review November 15, 2024 09:50
@smelc
Copy link
Contributor Author

smelc commented Nov 21, 2024

Being integrated in #971

Will close this one when #971 is merged

@smelc
Copy link
Contributor Author

smelc commented Nov 26, 2024

Closing, as #971 was merged

@smelc smelc closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants