Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more scripts to alonzo utxosspec #4405

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jun 14, 2024

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from lehins June 14, 2024 13:17
@aniketd aniketd changed the base branch from lehins/cip-0069 to master June 14, 2024 16:30
@aniketd aniketd force-pushed the aniketd/alonzo-utxos-tests branch from 514a295 to ba70257 Compare June 14, 2024 16:30
@lehins
Copy link
Collaborator

lehins commented Jun 19, 2024

There are a couple of nice tests in this PR, it will be great if you can finish 'em up

@aniketd aniketd force-pushed the aniketd/alonzo-utxos-tests branch from ba70257 to bd58778 Compare June 20, 2024 11:24
@aniketd aniketd requested a review from lehins June 20, 2024 11:25
@aniketd aniketd force-pushed the aniketd/alonzo-utxos-tests branch 4 times, most recently from c9785d7 to 8de4801 Compare June 27, 2024 13:52
@lehins lehins force-pushed the aniketd/alonzo-utxos-tests branch from 8de4801 to 3e49b77 Compare June 28, 2024 23:57
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for fixing those scripts

@lehins lehins enabled auto-merge June 28, 2024 23:58
@lehins lehins merged commit a53e43f into master Jun 29, 2024
125 checks passed
@lehins lehins deleted the aniketd/alonzo-utxos-tests branch June 29, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants