Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update executable-spec SRP #4442

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jun 26, 2024

Description

  • Fix the elusive compiler error

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/conformance-update-formal-spec branch 2 times, most recently from 3e107a7 to 6ba21a1 Compare June 27, 2024 13:12
@aniketd aniketd marked this pull request as ready for review June 27, 2024 13:13
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (as much as I can understand), just some minor comments.

It seems like the most significant change is that some types have changed to not use KeyHash but the integer representation thereof, is that about right?

You could squash the commits, since they only make sense together (you wouldn't want to rollback or keep one without the other)

Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good apart from what @teodanciu already pointed out.

@aniketd aniketd force-pushed the aniketd/conformance-update-formal-spec branch from 6ba21a1 to e1cb700 Compare June 28, 2024 10:58
@aniketd aniketd merged commit 5f43df4 into master Jun 28, 2024
125 checks passed
@aniketd aniketd deleted the aniketd/conformance-update-formal-spec branch June 28, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants