-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBODY refscript size check #4450
Conversation
e86598b
to
9508345
Compare
b9c91a5
to
546cd5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the PR really quick and it look great.
I'll go through more thoroughly tomorrow.
e339f7d
to
568bc24
Compare
568bc24
to
b9fcc9a
Compare
dd4897a
to
cbf2a18
Compare
Making sure that we never forge blocks that violate the new max ref scripts size limit per block that is enforced at the ledger level starting in Conway: IntersectMBO/cardano-ledger#4450 Also see #1168 for restoring a similar limit for the size of the total mempool in Conway.
cbf2a18
to
eae435a
Compare
eae435a
to
b88fa24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Thank you!!!
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/BbodySpec.hs
Outdated
Show resolved
Hide resolved
and keep the same behavior, invoking the transition function from Alonzo
b88fa24
to
4b1bf6c
Compare
4b1bf6c
to
553ed84
Compare
Addressed all comments, enabling automerge |
Description
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)