Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBODY refscript size check #4450

Merged
merged 8 commits into from
Jul 2, 2024
Merged

BBODY refscript size check #4450

merged 8 commits into from
Jul 2, 2024

Conversation

teodanciu
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch 5 times, most recently from e86598b to 9508345 Compare June 27, 2024 21:56
@teodanciu teodanciu marked this pull request as ready for review June 27, 2024 22:04
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch from b9c91a5 to 546cd5b Compare June 27, 2024 22:25
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the PR really quick and it look great.

I'll go through more thoroughly tomorrow.

eras/alonzo/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/alonzo/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Bbody.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Bbody.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Bbody.hs Outdated Show resolved Hide resolved
eras/babbage/impl/cardano-ledger-babbage.cabal Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Bbody.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-api/cardano-ledger-api.cabal Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch 2 times, most recently from e339f7d to 568bc24 Compare June 28, 2024 11:51
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch from 568bc24 to b9fcc9a Compare June 28, 2024 13:17
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch 3 times, most recently from dd4897a to cbf2a18 Compare July 1, 2024 09:18
github-merge-queue bot pushed a commit to IntersectMBO/ouroboros-consensus that referenced this pull request Jul 1, 2024
Making sure that we never forge blocks that violate the new max ref
scripts size limit per block that is enforced at the ledger level
starting in Conway:
IntersectMBO/cardano-ledger#4450

Also see #1168 for restoring a similar limit for the size of the total
mempool in Conway.
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch from cbf2a18 to eae435a Compare July 1, 2024 20:35
@teodanciu teodanciu requested review from lehins and amesgen July 1, 2024 20:36
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch from eae435a to b88fa24 Compare July 1, 2024 20:38
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
Thank you!!!

@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch from b88fa24 to 4b1bf6c Compare July 1, 2024 22:19
@teodanciu teodanciu force-pushed the td/bbody-refscript-size-check branch from 4b1bf6c to 553ed84 Compare July 1, 2024 22:32
@teodanciu
Copy link
Contributor Author

Addressed all comments, enabling automerge

@teodanciu teodanciu enabled auto-merge July 1, 2024 22:35
@teodanciu teodanciu merged commit 698a24c into master Jul 2, 2024
123 of 126 checks passed
@teodanciu teodanciu deleted the td/bbody-refscript-size-check branch July 2, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants