Prevent votes for non existent entities #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/prevent-votes-for-non-existent-entities
branch
2 times, most recently
from
817ea91
to
8a48f58
Compare
lehins
force-pushed
the
lehins/prevent-votes-for-non-existent-entities
branch
from
8a48f58
to
aa9d070
Compare
lehins
force-pushed
the
lehins/prevent-votes-for-non-existent-entities
branch
from
aa9d070
to
5c2e747
Compare
teodanciu
reviewed
Jun 29, 2024
teodanciu
reviewed
Jun 29, 2024
lehins
force-pushed
the
lehins/prevent-votes-for-non-existent-entities
branch
from
5c2e747
to
262414a
Compare
teodanciu
force-pushed
the
lehins/prevent-votes-for-non-existent-entities
branch
from
262414a
to
59bd48f
Compare
This check will prevent unknown voters from placing bogus votes on chain * Add an argument to `registerCommitteeHotKeys` * Change the return type of `resignCommitteeColdKey`
lehins
force-pushed
the
lehins/prevent-votes-for-non-existent-entities
branch
from
59bd48f
to
715f24d
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements protection against votes by unknown entities.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)