Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ts salvage newtylespecs #4575

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Ts salvage newtylespecs #4575

merged 2 commits into from
Sep 24, 2024

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Aug 27, 2024 •
edited
Loading

Description

Meant as a replacement for pull request #4314
Does several things

  1. Generalizes many of the instances in Test.Cardano.Ledger.Constrained.Conway.Instances to all Eras (not just Conway)
  2. Introduces two new types SimplePParams and SimplePPUpdate that are the used as the SimpleRep type across all Eras, makes it much easier to write specifications for PParams and PParramUpdates in all eras
  3. Writes specifications for all the Cardano types used in NewEpochState, EpochState, LedgerState, UTxOState etc.
  4. Significantly improves error reporting when the system is over constrained.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard force-pushed the ts-salvage-newtylespecs branch 4 times, most recently from 0442870 to ad19fcf Compare September 6, 2024 01:35
@TimSheard TimSheard force-pushed the ts-salvage-newtylespecs branch 10 times, most recently from da93b2d to 9fe0c4a Compare September 17, 2024 20:11
@TimSheard TimSheard marked this pull request as ready for review September 18, 2024 12:46
@TimSheard TimSheard requested a review from a team as a code owner September 18, 2024 12:46
@TimSheard TimSheard force-pushed the ts-salvage-newtylespecs branch from 55d9bfa to 34586a5 Compare September 24, 2024 08:42
@TimSheard
Added StateSpecs
27ebfb1 
Added names to variables in StateSpecs
Added better error messages, better printing of graphs
Added selector functions for SimplePParams
Added alternateShow for list based showing of Binary Specs (SumSpec and Prod)
Added HSpec tests
Imporoved error messages (especially for caseOn)
@TimSheard
Attempt to make Wellformed compile faster by adding {-# OPTIONS_GHC -…
5fc4f81 
…O1 #-}

in that and other files that compile slow (only when compiling using GHC 8.10.7
Also added Alonzo and Shelley TxOut HasSpec instances.
@TimSheard TimSheard force-pushed the ts-salvage-newtylespecs branch from b5250be to 5fc4f81 Compare September 24, 2024 18:20
@lehins lehins merged commit c051be1 into master Sep 24, 2024
152 of 154 checks passed
@lehins lehins deleted the ts-salvage-newtylespecs branch September 24, 2024 23:04
@lehins lehins mentioned this pull request Sep 24, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins left review comments

@Soupstraw Soupstraw Soupstraw approved these changes

@neilmayhew neilmayhew Awaiting requested review from neilmayhew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimSheard @lehins @Soupstraw