Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERFORMANCE FIX] rollback two additional metrics #5872

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

mgmeier
Copy link
Contributor

@mgmeier mgmeier commented Jun 4, 2024

Description

This PR presumably fixes a performance regression that was introduced by adding two Conway-exclusive metrics to the new tracing system.

Tracing those metrics will need a minor redesign wrt. the code location the trace is emitted. The current location exerts too much pressure on an STM value that's on the hot code path in the forging loop - which leads to the observed regression.

Till then, introduction of those two new metrics is rolled back.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@mgmeier mgmeier requested a review from a team as a code owner June 4, 2024 15:30
Copy link
Contributor

@jutaro jutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier mgmeier added this pull request to the merge queue Jun 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
[PERFORMANCE FIX] rollback two additional metrics
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 5, 2024
Copy link
Contributor

@NadiaYvette NadiaYvette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a straightforward backout.

@carbolymer carbolymer merged commit ebc3ae3 into master Jun 6, 2024
26 checks passed
@carbolymer carbolymer deleted the bench-8.11.0 branch June 6, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants