Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy tracing and OCI update #6042

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Legacy tracing and OCI update #6042

merged 5 commits into from
Nov 25, 2024

Conversation

johnalotoski
Copy link
Contributor

@johnalotoski johnalotoski commented Nov 22, 2024 •
edited
Loading

Description

  • Ensures legacy tracing is default via config when the node default itself changes to new tracing system
  • Fixes default OCI mainnet topology p2p json
  • Updates some OCI legacy cmds and repo references

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Required CI passes
  • Self-reviewed the diff

@johnalotoski johnalotoski requested review from a team as code owners November 22, 2024 16:11
mgmeier
mgmeier approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @johnalotoski

@mgmeier mgmeier added this pull request to the merge queue Nov 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
@mgmeier
Merge pull request #6042 from IntersectMBO/jl/legacy-tracing-and-oci-…
bb54dcd 
…update

Legacy tracing and OCI update
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 25, 2024
@mgmeier mgmeier added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit ef5f0a9 Nov 25, 2024
24 checks passed
@mgmeier mgmeier deleted the jl/legacy-tracing-and-oci-update branch November 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgmeier mgmeier mgmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnalotoski @mgmeier