Add an extra header parameter to BlockFetchConsensusInterface #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is currently called `selectionHeader`. This change allow us to use two header types in the interface. The `header` type, now is intended to convey additional information, in particular the slot time at which the header was downloaded. In this way we can address [this issue](IntersectMBO/ouroboros-consensus#1301) which allow us to simplify Consensus time conversions. Additionally, this change will enable us to remove `FromConsensus` data and the precondition of `headerForgeUTCTime`. The `selectionHeader` type will typically denote a raw header.
5 tasks
|
Closing as per this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is currently called
selectionHeader. This change allow us to use two header types in the interface. Theheadertype, now is intended to convey additional information, in particular the slot time at which the header was downloaded. In this way we can address thisissue which allow us to simplify Consensus time conversions. Additionally, this change will enable us to remove
FromConsensusdata and the precondition ofheaderForgeUTCTime.The
selectionHeadertype will typically denote a raw header.Description
reasonably detailed description of the pull request
Checklist
Quality
Maintenance
ouroboros-networkproject.