Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Drupal 11 support #83

Merged
merged 10 commits into from
Oct 30, 2024
Merged

Add Drupal 11 support #83

merged 10 commits into from
Oct 30, 2024

Conversation

joecorall
Copy link
Member

@joecorall joecorall commented Oct 28, 2024 •
edited
Loading

Relates to Islandora/documentation#2318

What does this Pull Request do?

  • Add Drupal 11 support
  • drops support for 10.2 and below due to drupal/rdf:3.0.0
  • ran phpcbf --standard=Drupal on the codebase

@joecorall
Copy link
Member Author

joecorall commented Oct 28, 2024 •
edited
Loading

Six tests for Drupal 11 are failing on

Test Errored (Drupal\Tests\jsonld\Kernel\JsonldHookTest::testAlterNormalizedJsonld)
Test Errored (Drupal\Tests\jsonld\Kernel\Normalizer\JsonldContentEntityNormalizerTest::testSimpleNormalizeJsonld)
Test Errored (Drupal\Tests\jsonld\Kernel\Normalizer\JsonldContentEntityNormalizerTest::testLocalizedNormalizeJsonld)
Test Errored (Drupal\Tests\jsonld\Kernel\Normalizer\JsonldContentEntityNormalizerTest::testDeduplicateEntityReferenceMappings)
Test Errored (Drupal\Tests\jsonld\Kernel\Normalizer\JsonldContentEntityNormalizerTest::testDeduplicateEntityReferenceIds)
Test Errored (Drupal\Tests\jsonld\Kernel\Normalizer\JsonldContentEntityNormalizerTest::testDuplicateEntityReferenceAndMappings)

Could not normalize object of type "Drupal\Core\TypedData\Plugin\DataType\IntegerData", no supporting normalizer found.

Fixed by 8a43ba8

@joecorall joecorall force-pushed the drupal-11 branch 2 times, most recently from f46dee4 to 01f5257 Compare October 28, 2024 17:21
@joecorall joecorall marked this pull request as ready for review October 29, 2024 15:42
@joecorall joecorall requested a review from a team October 29, 2024 15:42
@seth-shaw-asu seth-shaw-asu merged commit 8db4c55 into 3.x Oct 30, 2024
7 checks passed
@seth-shaw-asu seth-shaw-asu deleted the drupal-11 branch October 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-asu seth-shaw-asu seth-shaw-asu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joecorall @seth-shaw-asu