Add QueuedState resource
#47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, please no cargo fmt. I can't review if the diff contains a lot of noise. |
|
Done, sorry about that. Looking at it again this is a pretty naive implementation, I don't know how much overhead is involved in adding/remove resources but that could be an issue performance-wise if there are a lot of exit systems. I think it would be relatively easy to prevent unneeded operations on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
QueuedStateresource that is only available to exit systems which contains the state being transitioned to. Somewhat related to #8 which has been reverted since it was closed.Also
cargo fmthappened, I can undo the formatting if needed 😅