-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CMake and cibuildwheel, take 2 #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @JCGoran! I didn't get which instruction i Should follow, since in this thresd there are info different from readme.md |
Yes, the info is different because it's on another branch (the one this PR is tracking), have a look at https://github.com/JCGoran/coffe/blob/jelic/feature/cmake/README.md |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some trial and error, I think I managed to get COFFE to work seamlessly on both Linux and MacOS (both
arm64
andx86_64
) using CMake as the build system.Refer to the README to see how it works, but the short version for how to build COFFE (the Python version at least) on MacOS is:
pip install conan
and install the third-party dependenciesconan profile detect --force && conan install . --output-folder=_build --build=missing
brew install fftw gsl libconfig
bash scripts/install_other.sh cuba class
(sudo may be needed since it's writing to/opt
)pip install .
. Optional dependencies (for testing, docs, etc.) can be installed withpip install '.[all]'
(note the quotes around, you need them)For testing, you can do
python -m pytest -vvv tests/
(note that this may take some time to run).To make a Python version of COFFE you can send to others, you can do:
pip install cibuildwheel
cibuildwheel --platform macos
. If it complains about versioning, prependSETUPTOOLS_SCM_PRETEND_VERSION=[SOME VERSION]
, where[SOME VERSION]
should be something like3.0.2
I've also setup a CI that should build all of the wheels, that can then be uploaded.
Click here to download all (Python 3.8-3.12) MacOS wheels
@fsorrenti let me know if this works on your machine, or if you encounter any problems/need any clarifications.