Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow missing/empty cycle time files in timeseries #211

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Allow missing/empty cycle time files in timeseries #211

merged 7 commits into from
Nov 21, 2024

Conversation

asewnath
Copy link
Collaborator

@asewnath asewnath commented Nov 12, 2024 •
edited
Loading

Description

  • Added support for missing/empty cycle time files when running in timeseries mode
  • Adding requirements that work on discover milan nodes

Demonstration

Comparing two time series of different lengths:
time_series_omb

Timeseries with a missing cycle time:
time_series_omb

@asewnath asewnath marked this pull request as draft November 14, 2024 18:46
danholdaway
danholdaway requested changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some testing to show the use case of this feature?

requirements.txt Show resolved Hide resolved
@asewnath
Copy link
Collaborator Author

Could you add some testing to show the use case of this feature?

Yes, this PR is currently a draft

@asewnath asewnath marked this pull request as ready for review November 18, 2024 20:51
@asewnath asewnath requested a review from danholdaway November 18, 2024 20:51
danholdaway
danholdaway approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature and thanks for adding testing.

@danholdaway danholdaway merged commit 474199a into develop Nov 21, 2024
5 checks passed
@danholdaway danholdaway deleted the feature/timeseries_missing_obs branch November 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danholdaway danholdaway danholdaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asewnath @danholdaway