Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored function names in R/job_status_emails.R #81

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

teddyCodex
Copy link
Collaborator

Description

Refactored specified function names in R/summarize.R based on issue #7

Original Modified User Facing
make_job_results_url createJobResultsURL
format_job_args formatJobArgumentsHTML ✅  
get_job_message createJobStatusEmailMessage ✅  
send_job_status_email sendJobStatusEmail

Fixes issue #47

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex teddyCodex requested a review from the-mayer October 8, 2024 15:05
@the-mayer the-mayer self-assigned this Oct 8, 2024
@the-mayer the-mayer added the bug Something isn't working label Oct 8, 2024
@the-mayer the-mayer linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@the-mayer the-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, other than the incoming NAMESPACE

Nice work!

@the-mayer the-mayer merged commit e62a71c into JRaviLab:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the function names in R/job_status_emails.R
2 participants