Update the handling of arXiv/DOI #12348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
|
Why did you delete the branch and close the pr? You can simply push new commits, PR will be updated |
|
Hi @Siedlerchr I am new to open source i didn't know about that I decided to close the previous PR because it failed some unit tests, and I wanted to fix those issues thoroughly before raising a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12292
We improved the InspireHEP API so that the cite key is consistent, no matter how you search. Before, if you searched using an arXiv number or DOI, the cite key would show up as a long DOI URL, which wasn't ideal. Now, we’ve added a "texkeys" field that returns the proper cite key across all search types, making it easier to use.
Added a "texkeys" field to the API response for searches using unique identifiers like arXiv numbers.
This ensures that the cite key is consistent, whether you're searching normally or by arXiv number/DOI.
Updated the API to include the correct cite key for all search methods, improving usability.