Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh of calculation methods #197

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Pluimvee
Copy link
Contributor

@Pluimvee Pluimvee commented Oct 7, 2024

Code for proposal made in #194

The calculations of min, max, avg and perc should be very clear on what dataset they are performed.

With this change I tried to cleanup the calculation methods:

  • today[renamed from rotation]: calculations are executed on the price set of today and changes daily
  • publish: uses the dataset unfiltered. This means the calculations change whenever a new dataset is fetched
  • sliding-24: instead of taking a dataset from now till the end of tomorrow it now uses a dataset of 12hrs before till 12hrs after
  • sliding-12: same as above, but now using a 12hrs window (6hrs before and 6 hrs after)
  • forward-24: this filter uses the upcoming 24hrs of data, not including pasted data
  • forward-12: the same as above but using a 12hrs look ahead

@Pluimvee Pluimvee marked this pull request as draft October 7, 2024 18:38
@Pluimvee Pluimvee marked this pull request as ready for review October 7, 2024 18:38
…de-without-functional-changes

Adding comments, todo' s and sorted the code
@Roeland54
Copy link
Collaborator

The documentation of these methods should also be changed. You could use the content of the issue you made for this.

@Roeland54
Copy link
Collaborator

Roeland54 commented Oct 8, 2024

should we consider 'sliding-24' instead of 'sliding'? (also for forward?)

@Pluimvee Pluimvee marked this pull request as draft October 8, 2024 14:11
@Pluimvee

This comment was marked as outdated.

@Pluimvee Pluimvee marked this pull request as ready for review October 8, 2024 19:25
@Pluimvee
Copy link
Contributor Author

Pluimvee commented Oct 8, 2024

Please review after verifying/approving/merging Pull request #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants