-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh of calculation methods #197
Open
Pluimvee
wants to merge
29
commits into
JaccoR:main
Choose a base branch
from
Pluimvee:Change-Calculation-Modes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-without-functional-changes Adding comments, todo' s and sorted the code
The documentation of these methods should also be changed. You could use the content of the issue you made for this. |
Roeland54
reviewed
Oct 8, 2024
should we consider 'sliding-24' instead of 'sliding'? (also for forward?) |
This comment was marked as outdated.
This comment was marked as outdated.
…e/hass-entso-e into Change-Calculation-Modes
Please review after verifying/approving/merging Pull request #201 |
…uffle-code-without-functional-changes Adding comments and reschuffle code without functional changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for proposal made in #194
The calculations of min, max, avg and perc should be very clear on what dataset they are performed.
With this change I tried to cleanup the calculation methods: