-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Strict Mode in debug builds #271
Conversation
2d6a2c1
to
4a79fcd
Compare
And does it run...? |
4a79fcd
to
948d60f
Compare
Really sorry, I lazy-pasted here. Interestingly, you can successfully set Strict Mode in a static block. Just not in Application.onCreate. |
er, sorry, i mean that Strict Mode works, not the app. i'm looking into it... |
Strict Mode doesn't like Telescope hitting
|
AsyncTask is fine. We do something similar internally.
…On Wed, Feb 1, 2017 at 8:43 PM Eric Cochran ***@***.***> wrote:
Strict Mode doesn't like Telescope hitting getExternalFilesDir in cleanUp.
\0/
I guess that's not Telescope's responsibility. I see three options.
1. Throw cleanUp in an AsyncTask (gah) or something.
2. Set Strict Mode in the DebugViewContainer somewhere after cleanUp.
3. This is not worth it; close this nonsense PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#271 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEER5N04eNqGMcG3-GiFFhub6c8f0Wks5rYTSpgaJpZM4L0hm7>
.
|
getting caught on next case, the |
I don't have time to work on this. Linked in the issue for anybody that ever wants to do it. |
#270