Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Strict Mode in debug builds #271

Closed

Conversation

NightlyNexus
Copy link
Contributor

@NightlyNexus NightlyNexus commented Feb 1, 2017

@JakeWharton
Copy link
Owner

And does it run...?

@NightlyNexus
Copy link
Contributor Author

Really sorry, I lazy-pasted here.
But, yes, I checked now, and it works.

Interestingly, you can successfully set Strict Mode in a static block. Just not in Application.onCreate.

@NightlyNexus
Copy link
Contributor Author

er, sorry, i mean that Strict Mode works, not the app. i'm looking into it...

@NightlyNexus
Copy link
Contributor Author

Strict Mode doesn't like Telescope hitting getExternalFilesDir in cleanUp. \0/
I guess that's not Telescope's responsibility. I see three options.

  1. Throw cleanUp in an AsyncTask (gah) or something.
  2. Set Strict Mode in the DebugViewContainer somewhere after cleanUp.
  3. This is not worth it; close this nonsense PR.

@JakeWharton
Copy link
Owner

JakeWharton commented Feb 2, 2017 via email

@NightlyNexus
Copy link
Contributor Author

getting caught on next case, the inject into DebugView. I'll have to take another stab at it tomorrow.

@NightlyNexus
Copy link
Contributor Author

I don't have time to work on this. Linked in the issue for anybody that ever wants to do it.
Sorry for the noise.

@NightlyNexus NightlyNexus deleted the eric/strict-mode branch February 8, 2017 11:37
@NightlyNexus NightlyNexus restored the eric/strict-mode branch February 8, 2017 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants