Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teamup-rocketchat] Added support for custom config file and log path location via cli parameters #13

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

roshanlc
Copy link
Contributor

This PR addresses issues #6 and #7 since both issues are interrelated.

Changes Added :

  • Support for custom config file path via --config parameter
  • Support for custom log path via --logpath parameter
  • Shows usage and help screen with -h and --help parameter

@roshanlc roshanlc marked this pull request as ready for review January 11, 2023 05:50
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small initial comments, I still need to try it

teamup-rocketchat-bot/README.md Outdated Show resolved Hide resolved
teamup-rocketchat-bot/main.go Outdated Show resolved Hide resolved
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version is currently running for us as company and seems to work generally good.

you could also change the README for autostart it would now work simpler:
ExecStart=<full-path-of-bot>/teamup-rocketchat-bot --config <full-path-of-config-file>

teamup-rocketchat-bot/main.go Outdated Show resolved Hide resolved
teamup-rocketchat-bot/main.go Outdated Show resolved Hide resolved
teamup-rocketchat-bot/configuration.go Outdated Show resolved Hide resolved
teamup-rocketchat-bot/main.go Outdated Show resolved Hide resolved
@individual-it
Copy link
Member

also had a crash today, maybe because the rocket chat server was not reachable
image

@roshanlc
Copy link
Contributor Author

I will look into this. I will try to reproduce this locally and see how to prevent this in future.

teamup-rocketchat-bot/main.go Outdated Show resolved Hide resolved
teamup-rocketchat-bot/main.go Outdated Show resolved Hide resolved
@individual-it individual-it merged commit cb5ca43 into master Mar 24, 2023
@individual-it individual-it deleted the custom-log-config-path branch March 24, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants