-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[teamup-rocketchat] Added support for custom config file and log path location via cli parameters #13
Conversation
afac47c
to
a26fef3
Compare
a26fef3
to
c63874a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small initial comments, I still need to try it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version is currently running for us as company and seems to work generally good.
you could also change the README for autostart it would now work simpler:
ExecStart=<full-path-of-bot>/teamup-rocketchat-bot --config <full-path-of-config-file>
I will look into this. I will try to reproduce this locally and see how to prevent this in future. |
This PR addresses issues #6 and #7 since both issues are interrelated.
Changes Added :
--config
parameter--logpath
parameter-h
and--help
parameter