Skip to content

Commit

Permalink
Remove minSuccess arguments from remaining tests
Browse files Browse the repository at this point in the history 
Follow-up to #3961 where I forgot to remove this argument from these 2
tests because they are using `ParameterizedRepeatedIfExceptionsTest`
instead of `RepeatedIfExceptionsTest`.

Signed-off-by: Florian Hockmann <[email protected]>
  • Loading branch information
@FlorianHockmann
FlorianHockmann committed Sep 14, 2023
1 parent 69c860d commit 69ca01d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphCacheTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ public void testIndexUpdatesWithReindexAndRemove() throws InterruptedException,
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTest(boolean useStringId) throws InterruptedException {
super.simpleLogTest(useStringId);
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTestWithFailure(boolean useStringId) throws InterruptedException {
Expand Down
4 changes: 2 additions & 2 deletions janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,15 @@ public void testHasTTL() {
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTest(boolean useStringId) throws InterruptedException {
super.simpleLogTest(useStringId);
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTestWithFailure(boolean useStringId) throws InterruptedException {
Expand Down

1 comment on commit 69ca01d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 69ca01d Previous: 6205752 Ratio
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete 22464.854070383197 ms/op 22579.688640648168 ms/op 0.99
org.janusgraph.GraphCentricQueryBenchmark.getVertices 1931.868913861711 ms/op 1693.3271383287579 ms/op 1.14
org.janusgraph.MgmtOlapJobBenchmark.runClearIndex 223.75511413833993 ms/op 222.8017045478261 ms/op 1.00
org.janusgraph.MgmtOlapJobBenchmark.runReindex 595.2232265761905 ms/op 565.8578123657144 ms/op 1.05
org.janusgraph.JanusGraphSpeedBenchmark.basicCount 575.1305835522793 ms/op 458.33261599744327 ms/op 1.25
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 14437.487293313614 ms/op 13027.779634965924 ms/op 1.11
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingEmitRepeatSteps 49647.803344060005 ms/op 42947.178598 ms/op 1.16
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithSmallBatch 53846.07536250667 ms/op 47549.632632216664 ms/op 1.13
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.vertexCentricPropertiesFetching 110763.19770389999 ms/op 99834.0656897 ms/op 1.11
org.janusgraph.CQLMultiQueryBenchmark.getAllElementsTraversedFromOuterVertex 24019.006967934605 ms/op 21717.084192162452 ms/op 1.11
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithDoubleUnion 829.2241040580234 ms/op 763.9341528866134 ms/op 1.09
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithUnlimitedBatch 12549.737043584653 ms/op 12156.922564930786 ms/op 1.03
org.janusgraph.CQLMultiQueryBenchmark.getNames 23290.117562097952 ms/op 21623.489783162986 ms/op 1.08
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesThreePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 18509.99690156881 ms/op 16175.502236128377 ms/op 1.14
org.janusgraph.CQLMultiQueryBenchmark.getLabels 20338.439042455513 ms/op
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFilteredByAndStep 839.5723110840426 ms/op 828.1404002420064 ms/op 1.01
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFromMultiNestedRepeatStepStartingFromSingleVertex 31101.607647358094 ms/op 28624.24182517619 ms/op 1.09
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithCoalesceUsage 780.535241263995 ms/op 770.5690844916234 ms/op 1.01
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 47307.23798897619 ms/op 42753.61769863095 ms/op 1.11
org.janusgraph.CQLMultiQueryBenchmark.getIdToOutVerticesProjection 570.0570742676845 ms/op 518.0698862502832 ms/op 1.10
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithUnlimitedBatch 46342.27922270476 ms/op 45390.244630558336 ms/op 1.02
org.janusgraph.CQLMultiQueryBenchmark.getNeighborNames 22413.647621873886 ms/op 21751.645129234243 ms/op 1.03
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingRepeatUntilSteps 25579.72479350992 ms/op 22817.45437812944 ms/op 1.12
org.janusgraph.CQLMultiQueryBenchmark.getAdjacentVerticesLocalCounts 24880.333506261588 ms/op 21574.947662841663 ms/op 1.15

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.