Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new eBay members #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new eBay members #160

wants to merge 1 commit into from

Conversation

jerryjch
Copy link
Member

@jerryjch jerryjch commented Sep 4, 2020

Add new eBay members for contribution.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 4, 2020

CLA Check

@janusgraph-bot
Copy link

Please verify the committer name, email, and GitHub username association are all correct and match CLA records.

Signed-off-by: Jerry He <[email protected]>
@jerryjch
Copy link
Member Author

jerryjch commented Sep 4, 2020

@mbrukman Can you help to review and approve?

@mbrukman
Copy link
Member

mbrukman commented Sep 4, 2020

@jerryjch — we're migrating to LF EasyCLA, so I'm actually working on removing folks and companies from CLA_SIGNERS.yaml now, rather than adding new folks. As you can see, EasyCLA is running on this repo as well. :-)

Could you please ask someone who's able to sign the CCLA on behalf of eBay to follow these instructions to onboard eBay into LF EasyCLA? It'll be easy to add/remove folks via that interface, without any PRs going forward.

It's the same CCLA as was previously signed for JanusGraph, the only difference is that we removed the paragraph about asking folks to print out, sign, and email us the CLA document, since it's all electronic now. The rest remains the same, but they're welcome to read it and verify it themselves, of course.

@jerryjch
Copy link
Member Author

jerryjch commented Sep 5, 2020

@mbrukman Thanks for commenting here. Is this something recently enabled? Is there any workaround? I have to check with our internal legal on the LF EasyCLA.

@mbrukman
Copy link
Member

mbrukman commented Sep 6, 2020

@jerryjch — LF EasyCLA was enabled on all JanusGraph repos a while back, I think it was sometime in 2019 actually.

I've been slowly removing folks from CLA_SIGNERS.yaml in 2020 as folks submitted new PRs, which caused them to have to sign LF EasyCLA before we could accept their PR.

@jerryjch
Copy link
Member Author

jerryjch commented Sep 7, 2020

Hi, @mbrukman
How will contributors be added via that interface in the future?

@mbrukman
Copy link
Member

mbrukman commented Sep 8, 2020

@jerryjch — once eBay is onboarded as a CCLA signer for the JanusGraph project, new committers can apply to join the eBay organization, and the eBay organization managers can approve individuals to join the organization, once they request to join the company.

Whenever a person submits a PR to JanusGraph, and they're either not an ICLA signer, nor a member of an organization that signed the CCLA, they'll get a message (like you see at the top of this PR) where they can click on the URL and onboard themselves into LF EasyCLA and then choose an organization to join.

LF EasyCLA managers will use the same UI that they use to sign the JanusGraph CCLA to review/approve individuals joining the organization.

@janusgraph-bot
Copy link

Please verify the committer name, email, and GitHub username association are all correct and match CLA records.

@mbrukman
Copy link
Member

@jerryjch — given that eBay has signed the Linux Foundation CCLA (as evidenced in JanusGraph/janusgraph-foundationdb#50), can we close this PR?

As we're moving to using LF EasyCLA exclusively, I'd actually like to remove the eBay section in the YAML config file, and have everyone at eBay add themselves to the eBay org in LF EasyCLA and use that as the canonical source going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants