Fix gray tint. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Set mm_sd_v14 as the default instead of v15, as most end users tend to prefer it -Load actual motion modules from the model folder instead of hardcoding v14 and v15 in the dropdown -Add support for webp and apng file formats -Add quality sliders and lossless options for webp and apng -Add ability to format the file names -Add ability to output to a custom folder, along with named subdirectories similar to the feature set for images
-Brought injection code up to parity with Kosinkadink's ComfyUI's implementation -Updated motion_module -Updated groupnorm hack -Removed apng option, it just doesn't work well in imageio's implementation, may return in future -Add option to always save videos -Add infotext to video generations -Set UI parameters from infotext when pasting/restoring from params.txt -Separated settings into separate py file -Updated info for options -made some function names more descriptive and moved some code around for readbility -Make it so the infotext shown underneath the video after a generation reflects the actual video, not just main prompt
-Fixes an issue that would occur when trying to generate images after generating video. No longer asserts.
JaredTherriault
force-pushed
the
master
branch
from
e303b1e to
222d40f
Compare
|
Hey, thanks for the heads up! Would you be able to close this PR, pull latest, then reimplement the changes in a new commit? This change actually reverts a lot of recent changes due to the aggregation of commits. I could also just remove the DDIM check myself, but I want you to have the credit for the find and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the code from the upstream and fixed it too. In the upstream the DDIM parameters are only set if the DDIM sampler is used for generation but until then the gray noise is always present. However, as soon as you use DDIM once it's fixed for all samplers (until you restart SD that is). So I simply changed the code to always execute it.